<table><tr><td style="">simgunz marked an inline comment as done.<br />simgunz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8056" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><a href="https://phabricator.kde.org/p/simgunz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@simgunz</a> If you have no further changes planned for this Diff and <a href="https://phabricator.kde.org/D8670" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8670</a>, I could land both on your behalf. Contact information of non-developers are private by default on identity.kde.org, but I found some in <a href="https://github.com/simgunz/redshift-plasmoid" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/simgunz/redshift-plasmoid</a>. Are those okay to use for the authorship (name + email)?</p></blockquote>
<p>I don't need to add anything so you can land both. The contact information you have found are fine. Is it there a way to make my contact info in kde identity public? I couldn't find an option for it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Stumbled upon this too some time ago, amazingly you used the very same workaround I applied back then. Looking at <a href="https://en.wikipedia.org/wiki/Esc_key" class="remarkup-link" target="_blank" rel="noreferrer">https://en.wikipedia.org/wiki/Esc_key</a> the similar looking glyph seems intentional, so I don't see a chance to convince Phab upstream to change this. Just embrace and use it, maybe we all get accustomed after a while :) At least we get tooltips for all those symbols: <kbd title="Escape" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⎋</kbd><span class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd title="Command" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⌘</kbd><span class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd title="Option" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⌥</kbd></p></blockquote>
<p>Wow. Never saw that glyph before. One never finish learning.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>As for the <kbd title="Down" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">↓</kbd> and completion popup issues, the root cause seems to be that we have one input line but two overlapping "lists", which is really weird conceptually and gets complex quite fast as you noticed. A (quick to talk about, slow to implement) idea would be to get rid of the completion popup even for advanced users and merge those results (recent inputs, but also some other search results like <tt style="background: #ebebeb; font-size: 13px;">kmimetypefinder</tt> which are not even in a category!?) into the list view as a new section.</p>
<p>This definitely needs more thinking, no need to rush…</p></blockquote>
<p>Yes, doesn't seems trivial. We can talk about it.</p>
<p>One last note on this modification. Given that the previous default was to use <tt style="background: #ebebeb; font-size: 13px;">PopupCompletion</tt>, it means that most of the users out there have this setting configured. And if they are like me, most of them don't even know they can change this behavior. If there will be any type of announcement or changelog regarding this change, it may be useful to explicitly suggest to change to completion <tt style="background: #ebebeb; font-size: 13px;">None</tt> in order to fully enjoy the new feature without the popup covering the tree.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>openwithdialog-filter-app-tree</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8056" rel="noreferrer">https://phabricator.kde.org/D8056</a></div></div><br /><div><strong>To: </strong>simgunz, dfaure, Frameworks, VDG, ngraham, rkflx<br /><strong>Cc: </strong>rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, Frameworks<br /></div>