<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8619" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8619#inline-38038" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesview.cpp:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">virtual</span></span><span class="bright"> </span><span class="n">QSize</span> <span style="color: #004012">sizeHint</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStyleOptionViewItem</span> <span style="color: #aa2211">&</span><span class="n">option</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QSize</span> <span style="color: #004012">sizeHint</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStyleOptionViewItem</span> <span style="color: #aa2211">&</span><span class="n">option</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QModelIndex</span> <span style="color: #aa2211">&</span><span class="n">index</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">Q_DECL_OVERRIDE</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">v<span class="bright">irtual</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">v</span>oid</span> <span style="color: #004012">paint</span><span class="p">(</span><span class="n">QPainter</span> <span style="color: #aa2211">*</span><span class="n">painter</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">paint</span><span class="p">(</span><span class="n">QPainter</span> <span style="color: #aa2211">*</span><span class="n">painter</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">re-indent after the removal of "virtual"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8619#inline-38041" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesview.cpp:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">v<span class="bright">irtual</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">v</span>oid</span> <span style="color: #004012">paint</span><span class="p">(</span><span class="n">QPainter</span> <span style="color: #aa2211">*</span><span class="n">painter</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">paint</span><span class="p">(</span><span class="n">QPainter</span> <span style="color: #aa2211">*</span><span class="n">painter</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QStyleOptionViewItem</span> <span style="color: #aa2211">&</span><span class="n">option</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QModelIndex</span> <span style="color: #aa2211">&</span><span class="n">index</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">Q_DECL_OVERRIDE</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here, please re-indent after the removal of "virtual"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8619#inline-38040" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesview.cpp:737</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KFilePlacesViewDelegate</span> <span style="color: #aa2211">*</span><span class="n">delegate</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">dynamic_cast</span><span style="color: #aa2211"><</span><span class="n">KFilePlacesViewDelegate</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">itemDelegate</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">delegate</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You use qobject_cast elsewhere, why not here too?</p>
<p style="padding: 0; margin: 8px;">Or even... you use static_cast for the delegate in 90% of the code, why two uses of qobject_cast?</p>
<p style="padding: 0; margin: 8px;">If it's mandatory for the delegate to be a KFilePlacesViewDelegate, it's mandatory everywhere, right?</p>
<p style="padding: 0; margin: 8px;">(too bad setItemDelegate isn't virtual, we could have caught it there...)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8619" rel="noreferrer">https://phabricator.kde.org/D8619</a></div></div><br /><div><strong>To: </strong>mlaurent, Frameworks, ervin, dfaure<br /><strong>Cc: </strong>dfaure, ngraham<br /></div>