<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8387" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8387#inline-35667" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kio_smb.cpp:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">SMBSlave</span><span style="color: #aa2211">::</span><span class="n">SMBSlave</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QByteArray</span><span style="color: #aa2211">&</span> <span class="n">pool</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span><span style="color: #aa2211">&</span> <span class="n">app</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa2211">:</span> <span class="n">SlaveBase</span><span class="p">(</span> <span style="color: #766510">"smb"</span><span class="p">,</span> <span class="n">pool</span><span class="p">,</span> <span class="n">app</span> <span class="p">),</span> <span class="n">m_openFd</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa2211">:</span> <span class="n">SlaveBase</span><span class="p">(</span> <span style="color: #766510">"smb"</span><span class="p">,</span> <span class="n">pool</span><span class="p">,</span> <span class="n">app</span> <span class="p">),</span> <span class="n">m_openFd</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)<span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="n">m_enableEEXISTWorkaround</span><span class="p">(</span><span class="n">checkEnableEEXISTWorkaround</span><span class="p">())</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While at it, I'd move <tt style="background: #ebebeb; font-size: 13px;">m_openFd</tt> on its own line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8387#inline-35666" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kio_smb_browse.cpp:521</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">bool</span> <span class="n">SMBSlave</span><span style="color: #aa2211">::</span><span class="n">workaroundEEXIST</span><span class="p">(</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">errNum</span><span class="p">)</span> <span style="color: #aa4000">const</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe call it <tt style="background: #ebebeb; font-size: 13px;">needsWorkaroundEEXIST()</tt>?</p>

<p style="padding: 0; margin: 8px;">Current name seems to imply the method <em>is</em> the workaround, while it just tells us whether we need the workaround.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8387#inline-35665" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kio_smb_browse.cpp:523</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">return</span> <span class="n">errNum</span> <span style="color: #aa2211">==</span> <span class="n">EEXIST</span> <span style="color: #aa2211">&&</span> <span class="n">m_enableEEXISTWorkaround</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">4 spaces here</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8387" rel="noreferrer">https://phabricator.kde.org/D8387</a></div></div><br /><div><strong>To: </strong>madcatx, ngraham, davidedmundson, elvisangelaccio, Frameworks<br /><strong>Cc: </strong>graesslin, z3ntu<br /></div>