<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7929" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7929#147742" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7929#147742</a>, <a href="https://phabricator.kde.org/p/elvisangelaccio/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@elvisangelaccio</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream?</p></div>
</blockquote>
<p>It's not that easy - QColumnView is practically abandoned upstream (with its huge amount of bugs it received basically no fixes at all), I really dislike the upstream contribution process (not really a valid reason, I know, but it would definitely make it much harder to fix bugs) and KColumnView breaks compatibility in certain ways. Anyway, I did not totally abandon that idea, but it really needs some testing before attempting upstreaming it. I really tried hard to make QColumnView work properly, but it's just impossible.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7929#147738" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7929#147738</a>, <a href="https://phabricator.kde.org/p/lbeltrame/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@lbeltrame</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>A screenshot before/after (or just after, since it is an addition) would be helpful in this case, since it is a visual change.</p></div>
</blockquote>
<p>Sure!<br />
Before: <a href="https://i.imgur.com/FXdLwca.png" class="remarkup-link" target="_blank" rel="noreferrer">https://i.imgur.com/FXdLwca.png</a><br />
After: <a href="https://i.imgur.com/L2WgmmG.png" class="remarkup-link" target="_blank" rel="noreferrer">https://i.imgur.com/L2WgmmG.png</a><br />
Video (uploaded with the column view file dialog :-) ): <a href="https://gfycat.com/gifs/detail/HiddenShallowAnteater" class="remarkup-link" target="_blank" rel="noreferrer">https://gfycat.com/gifs/detail/HiddenShallowAnteater</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7929" rel="noreferrer">https://phabricator.kde.org/D7929</a></div></div><br /><div><strong>To: </strong>fvogt, Frameworks<br /><strong>Cc: </strong>elvisangelaccio, lbeltrame, Frameworks<br /></div>