<table><tr><td style="">maxrd2 added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7676" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7676#inline-31444" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krunproxy.cpp:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">service</span> <span style="color: #aa2211">=</span> <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">serviceByDesktopPath</span><span class="p">(</span><span class="n">filePath</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">return</span> <span class="n">KRun</span><span style="color: #aa2211">::</span><span class="n">runService</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">service</span><span class="p">,</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span><span class="p">(),</span> <span style="color: #aa4000">nullptr</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While I'm at it should i also change to runApplication() here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7676#inline-31443" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krunproxy.cpp:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">service</span> <span style="color: #aa2211">=</span> <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">serviceByDesktopName</span><span class="p">(</span><span class="n">serviceName</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">service</span> <span style="color: #aa2211">&&</span> <span class="n">service</span><span style="color: #aa2211">-></span><span class="n">isApplication</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">KRun</span><span style="color: #aa2211">::</span><span class="n">runApplication</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">service</span><span class="p">,</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span><span class="p">(),</span> <span style="color: #aa4000">nullptr</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Am not sure if service->isApplication() check here is needed... can someone confirm please?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7676" rel="noreferrer">https://phabricator.kde.org/D7676</a></div></div><br /><div><strong>To: </strong>maxrd2, davidedmundson<br /><strong>Cc: </strong>broulik, Frameworks<br /></div>