<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7484" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good to me.</p>
<p>Just two questions:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The section is "Scripts", is that really a script, or would another category like "Scientific" or "Other" be more suitable?</li>
<li class="remarkup-list-item">Is the demo code from you, and as such also MIT licensed?</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7484" rel="noreferrer">https://phabricator.kde.org/D7484</a></div></div><br /><div><strong>To: </strong>pablooliveira, dhaumann<br /><strong>Cc: </strong>Frameworks, cullmann, vkrause, dhaumann<br /></div>