<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7292" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7292#135318" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7292#135318</a>, <a href="https://phabricator.kde.org/p/dhaumann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@dhaumann</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet...</p></div>
</blockquote>
<p>Well, I can think of other reasons:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">you wouldn't add a new enum value unless there is a good reason to (and a real use case). So why keep an unused value?</li>
<li class="remarkup-list-item">If we do keep it around, we should document it in <a href="https://phabricator.kde.org/D7287" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7287</a>, but how? It's not clear what this action is supposed to do.</li>
<li class="remarkup-list-item">Less code to maintain/fix/port in the long term.</li>
</ul>
<p>If someone complains, I guess we can always un-deprecate it?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7292" rel="noreferrer">https://phabricator.kde.org/D7292</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, Frameworks<br /><strong>Cc: </strong>dhaumann<br /></div>