<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7078" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>of course we do that :-)</p></blockquote>
<p>We're not.</p>
<p>Kwin does not check if a client has a selection. <br />
It merely checks if the client has an interface from a selection can be fetched, it does not check that device actually has a valid selection.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>you think that we should not even send out the DataOffer I think that's a separate thing,</p></blockquote>
<p>No, that's not what I think.<br />
We're getting crosswired. I'll submit my coment as a patch, so maybe you'll understand what I'm trying to say.</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Please note that I doubt that your suggestion would help against the crash I fixed here.</p></blockquote>
<p>If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7078" rel="noreferrer">https://phabricator.kde.org/D7078</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma, Frameworks<br /><strong>Cc: </strong>anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas<br /></div>