<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7289" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks already good, but maybe we can do better with the lineEmptyContext? Also, we have things like fallthroughContext, if no rule matches at all in a context.</p>
<p>I suggest one more review iteration.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7289#inline-29674" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">email.xml:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"email"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'"[a-zA-Z0-9. \-]+"\s*<[a-zA-Z0-9.\-]+\@[a-zA-Z0-9.\-]+>'</span></span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"string"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'".*"'</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">/</span>></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><keyword</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Common Header"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"header-content"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"header-names"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">column=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"0"</span></span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Other Header"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"header-content"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"[0-9a-zA-Z-.]+:\s"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">column=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"0"</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">/></span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #74777d"><span class="bright"><!-- we would want to switch to a body context here when encountering an empty newline, but that's not supported, is it? --</span>></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure, but is underscore '_' also allowed?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7289#inline-29675" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">email.xml:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"string"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'".*"'</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">/</span>></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"string"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"'.*'</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Other Header"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"header-content"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"[0-9a-zA-Z-.]+:\s"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">column=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"0"</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">/></span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #74777d"><span class="bright"><!-- we would want to switch to a body context here when encountering an empty newline, but that's not supported, is it? --</span>></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Content Boundary"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"--[0-9a-zA-Z.-]+(--)?</span></span><span class="bright"></span><span class="err"><span class="bright">$</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">column=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"0</span>"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Search for lineEmptyContext here: <a href="https://docs.kde.org/trunk5/en/applications/katepart/highlight.html" class="remarkup-link" target="_blank" rel="noreferrer">https://docs.kde.org/trunk5/en/applications/katepart/highlight.html</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7289#inline-29676" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">email.xml:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExp</span>r</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"<span class="bright">indent3</span>"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"<span class="bright">#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"^[|>]\s*[|>]\s*[|>].*</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"indent2"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"^[|>]\s*[|>].*</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"indent1"</span></span><span class="bright"> </span><span style="color: #354bb3">context<span class="bright">=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"^[|>].*"</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">/</span>></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><DetectCha</span>r</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"<span class="bright">Comment</span>"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"<span class="bright">comment-context"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">char=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"(</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"><RegExpr</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Address"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">context=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"#stay"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">String=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"<?[a-zA-Z0-9.-]+@[a-zA-Z0-9.-]+>?</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #00702a"><span class="bright"></</span>context></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">'_' missing?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7289" rel="noreferrer">https://phabricator.kde.org/D7289</a></div></div><br /><div><strong>To: </strong>vkrause, Framework: Syntax Hightlighting, kwrite-devel<br /><strong>Cc: </strong>dhaumann, Frameworks<br /></div>