<table><tr><td style="">sitter added a subscriber: apol.<br />sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7008" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7008#133756" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7008#133756</a>, <a href="https://phabricator.kde.org/p/habacker/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@habacker</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7008#133755" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7008#133755</a>, <a href="https://phabricator.kde.org/p/sitter/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@sitter</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7008#133644" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7008#133644</a>, <a href="https://phabricator.kde.org/p/sitter/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@sitter</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><a href="https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11</a> when not xcompiling the targets are fairly useless and don't need to get imported at all)</p></div>
</blockquote></div>
</blockquote>
<p>What content does the file included by</p>
<p>include("${KCONFIGCOMPILER_PATH}")</p>
<p>should have to be usable ?</p></div>
</blockquote>
<p>The exported executable. Basically: CMake has two Targets.cmake files. One for the library artifacts and one completely separate one for the helpers. This allows including either/or depending on what is needed and by extension including the host's helpers when cross compiling</p>
<p>Further references:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">here we install the binary and EXPORT it into KF5ConfigCompilerTargets <a href="https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/CMakeLists.txt;023e3ecfe985e09f786134fc28793d24383998f8$23" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/CMakeLists.txt;023e3ecfe985e09f786134fc28793d24383998f8$23</a></li>
<li class="remarkup-list-item">here we install the targets <a href="https://phabricator.kde.org/source/kconfig/browse/master/CMakeLists.txt;023e3ecfe985e09f786134fc28793d24383998f8$81" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/CMakeLists.txt;023e3ecfe985e09f786134fc28793d24383998f8$81</a></li>
<li class="remarkup-list-item">note that KF5ConfigCompilerTargets (helper binaries) is different from KF5ConfigTargets (library artifacts)</li>
<li class="remarkup-list-item">in our Config.cmake we always include our library targets <a href="https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$5" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$5</a></li>
<li class="remarkup-list-item">but depending on xcompiling we'll either include the helper binary from the host's KF5ConfigCompilerTargets or ours when not xcompiling <a href="https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11</a></li>
</ul>
<p>This ultimately results in <tt style="background: #ebebeb; font-size: 13px;">find_package(KF5Config)</tt> always importing <tt style="background: #ebebeb; font-size: 13px;">KF5::kconfig_compiler</tt>, but depending on the xcompiling stuff it may be the host's.</p>
<p>This would work pretty much exactly the same for sonnet with the additional change that the xcompile if inside the source itself (<a href="https://phabricator.kde.org/source/sonnet/browse/master/data/CMakeLists.txt;c4c007cc3c0b9ee0ee46e91d026752662dd867a4$18" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/sonnet/browse/master/data/CMakeLists.txt;c4c007cc3c0b9ee0ee46e91d026752662dd867a4$18</a>) would change to <tt style="background: #ebebeb; font-size: 13px;">find_file; include</tt> boilerplate of <a href="https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$12" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$12</a></p>
<p>I think <a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@apol</a> wrote the initial implementation of this magic and can probably answer questions better than me though :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R246 Sonnet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7008" rel="noreferrer">https://phabricator.kde.org/D7008</a></div></div><br /><div><strong>To: </strong>vkrause, Frameworks, cordlandwehr<br /><strong>Cc: </strong>apol, sitter, sandsmark, habacker, dfaure<br /></div>