<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6914" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>First of all, I also think this is a good patch.</p>

<p>There are some parts with debug output, some parts with warnings (e.g. Q_FUNC_INFO), I guess this is temporary? :-)<br />
Besides that, there are several parts with commented out code - is that work in progress, or is the commented out code not required at all anymore?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6914#inline-28340" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katescript.cpp:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">bt</span> <span style="color: #aa2211">+=</span> <span class="n">m_engine<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-</span>></span><span class="n">uncaughtExceptionBacktrace</span><span class="p">().</span><span class="n">join</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">))</span> <span style="color: #aa2211">+</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>    bt += m_engine>uncaughtExceptionBacktrace().join(QStringLiteral("\n")) + QLatin1Char('\n');</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If there is no equivalent to get the backtrace, just delete this line.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6914#inline-28341" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katescript.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_engine</span><span style="color: #aa2211">-></span><span class="n">clearExceptions</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>    m_engine->clearExceptions();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If such a call is not required, please delete.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6914#inline-28342" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katescript.cpp:150</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_engine</span><span style="color: #aa2211">-></span><span class="n">globalObject</span><span class="p">().</span><span class="n">setProperty</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"require"</span><span class="p">),</span> <span class="n">functions</span><span class="p">.</span><span class="n">property</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"require"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_engine</span><span style="color: #aa2211">-></span><span class="n">globalObject</span><span class="p">().</span><span class="n">setProperty</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"require_guard"</span><span class="p">),</span> <span class="n">m_engine</span><span style="color: #aa2211">-></span><span class="n">newObject</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If I remember correctly, Christoph once said it as quite a hassle to get this include guard working correctly. Are you sure it works or are there possibly issues due to some other behavior in QJSEngine?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6914#inline-28344" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katescriptdocument.h:63-65</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span style="color: #004012">text</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Cursor</span> <span style="color: #aa2211">&</span><span class="n">from</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Cursor</span> <span style="color: #aa2211">&</span><span class="n">to</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span style="color: #004012">text</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Range</span> <span style="color: #aa2211">&</span><span class="n">range</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span style="color: #004012">text</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QJSValue</span> <span style="color: #aa2211">&</span><span class="n">jsrange</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If I understand correctly, you are adding an overload for all functions that have KTextEditor::Cursor or Range in the parameter.<br />
Does that imply we could remove the Q_INVOKABLE part of the overloads that use the complex types such as Cursor and Range?</p>

<p style="padding: 0; margin: 8px;">If so, I would be in favor of doing this, just to make this explicit.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6914#inline-28350" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katescripthelpers.cpp:178</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">/// helper function to do the substitution from QtScript > QVariant > real values</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">KLocalizedString</span> <span class="n">substituteArguments</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KLocalizedString</span> <span style="color: #aa2211">&</span><span class="n">kls</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVariantList</span> <span style="color: #aa2211">&</span><span class="n">arguments</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">max</span> <span style="color: #aa2211">=</span> <span style="color: #601200">99</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>KLocalizedString substituteArguments(const KLocalizedString &kls, const QVariantList &arguments, int max = 99)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this all not required anymore?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R252 Framework Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6914" rel="noreferrer">https://phabricator.kde.org/D6914</a></div></div><br /><div><strong>To: </strong>carewolf, cullmann, dhaumann, Frameworks<br /><strong>Cc: </strong>cullmann, Frameworks<br /></div>