<table><tr><td style="">dhaumann requested changes to this revision.<br />dhaumann added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6867" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks almost good, but I think another iteration would be nice.</p>

<p>I assume we cannot relicense to MIT?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6867#inline-28182" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powershell.xml:5</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #354bb3">version=</span><span style="color: #766510">"1"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"3.4"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #354bb3">extensions=</span><span style="color: #766510">"*.ps1;*.ps1m;*.ps1d"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If I remember correctly, the default style dsBuiltIn was added with the first release of KDE Frameworks 5, see all bold entries here:<br />
<a href="https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/" class="remarkup-link" target="_blank" rel="noreferrer">https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/</a></p>

<p style="padding: 0; margin: 8px;">So kateversion="5.0" is required here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6867#inline-28183" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powershell.xml:918</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"String"</span>       <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsString"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"HereString"</span>       <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsString"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Comment"</span>      <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsComment"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since we require kateversion 5.0 anyways, we could also use dsVerbatimString instead of dsString.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6867#inline-28184" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powershell.xml:922</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Symbol"</span>       <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsNormal"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Variable"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsKeyword"</span> <span style="color: #354bb3">color=</span><span style="color: #766510">"#5555FF"</span> <span style="color: #354bb3">selColor=</span><span style="color: #766510">"#ffffff"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">spellChecking=</span><span style="color: #766510">"false"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Special Variable"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsKeyword"</span> <span style="color: #354bb3">color=</span><span style="color: #766510">"#5555FF"</span> <span style="color: #354bb3">selColor=</span><span style="color: #766510">"#ffffff"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"1"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">spellChecking=</span><span style="color: #766510">"false"</span> <span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Suggestion: use dsVariable for variables, and remove all hardcoded colors and bold and italic.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6867#inline-28185" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powershell.xml:923</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Variable"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsKeyword"</span> <span style="color: #354bb3">color=</span><span style="color: #766510">"#5555FF"</span> <span style="color: #354bb3">selColor=</span><span style="color: #766510">"#ffffff"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">spellChecking=</span><span style="color: #766510">"false"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Special Variable"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsKeyword"</span> <span style="color: #354bb3">color=</span><span style="color: #766510">"#5555FF"</span> <span style="color: #354bb3">selColor=</span><span style="color: #766510">"#ffffff"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"1"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">spellChecking=</span><span style="color: #766510">"false"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #00702a"></itemDatas></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dsConstant would be better.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6867" rel="noreferrer">https://phabricator.kde.org/D6867</a></div></div><br /><div><strong>To: </strong>vkrause, dhaumann, vonreth<br /><strong>Cc: </strong>Frameworks<br /></div>