<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6116" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>There is just one minor problem, with two stateChanged() signals you will need to specify to which signal you want<br />
to connect to when using Qt5 syntax for signals/slots and without that you won't compile current code, i.e. of plasma-nm</p></blockquote>
<p>I think we're going to have to treat overloading signals as an API break. Current plasma needs to compile with new frameworks.</p>
<p>There's a line in the Qt wiki page that implies they now have that policy.</p>
<p>"… but we have been adding overloads in past minor releases of Qt because taking the address of a function was not a use case we support. But now this would be impossible without breaking the source compatibility. "</p>
<p>can you find a new signal name and emit both for compatibility?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6116" rel="noreferrer">https://phabricator.kde.org/D6116</a></div></div><br /><div><strong>To: </strong>jgrulich, lvsouza<br /><strong>Cc: </strong>davidedmundson, Frameworks<br /></div>