<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122551/">https://git.reviewboard.kde.org/r/122551/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 13th, 2015, 12:06 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You're aware that Kate (and any other decent editor) has session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened.</p></pre>
</blockquote>
<p>On February 13th, 2015, 9:28 p.m. UTC, <b>Thomas Murach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, I use sessions quite frequently. To me the need to re-open many/all recently opened files occurs <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">within</em> sessions. One session (in my case) corresponds to one project / code base containing usually many files, so I don't have all of them open. Then if I think I'm done fixing a bug or similar, I close files I won't need again in the next days, and the situation described above has started.</p></pre>
</blockquote>
<p>On April 6th, 2015, 12:53 a.m. UTC, <b>Thomas Murach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, so, what's the status?</p></pre>
</blockquote>
<p>On September 3rd, 2016, 11:28 p.m. UTC, <b>Thomas Murach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wow, this little discussion was dormant for quite a while now - let's finish it. Personally I still think I'd like to have such a feature, every once in a while I miss it. Accepting the patch is of course up to you, and I won't insist on having it included.
In case it is accepted: I haven't tested it since then, so one should have another look.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Next use case: recently my X session crashed, so that (in this case) Kile (TeX editor) lost it's session information and started with a blank new file instead of the previous list of open files. So now I had to go and open all files one by one, instead of simply clicking "open all recent files".</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On February 23rd, 2015, 11:52 p.m. UTC, Thomas Murach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Thomas Murach.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2015, 11:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've always been looking for a feature (mostly in Kate et al.) to open all recently opened files at once. Every once in a while I think I'm done with some source code editing, realise that I'm not, and then have to click through all files one by one. With this patch opening all files at once gets possible. So much for the background. Still there are some open questions:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Is such a feature wanted at all?
2) Is the code quality/style ok?
3) Last but not least: This patch will work nicely with kate, presumably also with okular and some others, but I guess it will not work as expected with Kaffeine, for example, as new files which are to be opened will not get appended to a playlist but instead each file will get opened for an instance and then be replaced by the next opened file. Possible solutions: In principle it would be possible to add another signal passing a list of URLs to applications, which then have to define a suitable slot. Alternatively this patch could just not be applied and the feature I'm trying to introduce could be added to kate only... (I don't prefer that option ;) )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, what are your opinions, comments, ideas? Thanks in advance!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS I hope the reviewer group "kdeframeworks" is the right one...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't run KF5 on a daily basis, but in a Docker session the patch works nicely with Kate.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/krecentfilesaction.h <span style="color: grey">(06965d4)</span></li>
<li>src/krecentfilesaction.cpp <span style="color: grey">(40fdf93)</span></li>
<li>src/krecentfilesaction_p.h <span style="color: grey">(2c690a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122551/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>