<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6070" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I am not super sure about the struct -> class. Why?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6070#inline-24932" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractortest.cpp:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">resultMpc</span><span class="p">.</span><span class="n">types</span><span class="p">().</span><span class="n">size</span><span class="p">(),</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">resultMpc</span><span class="p">.</span><span class="n">types</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">first</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>),</span> <span class="n">Type</span><span style="color: #aa2211">::</span><span class="n">Audio</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">resultMpc</span><span class="p">.</span><span class="n">types</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">at</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">),</span> <span class="n">Type</span><span style="color: #aa2211">::</span><span class="n">Audio</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Probably more elegant to use <tt style="background: #ebebeb; font-size: 13px;">constFirst</tt> than <tt style="background: #ebebeb; font-size: 13px;">at(0)</tt>.</p>

<p style="padding: 0; margin: 8px;">FWIW note that in this case we're patching so the warning is gone (which is not bad per se) but it's not like the software will be much better after this change. ^^'</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6070" rel="noreferrer">https://phabricator.kde.org/D6070</a></div></div><br /><div><strong>To: </strong>mgallien, Frameworks<br /><strong>Cc: </strong>apol<br /></div>