<table><tr><td style="">elvisangelaccio created this revision.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6045" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Stand-alone popup menus are <Menu> elements that are children of the<br />
top-level <gui> element. Their initial parent is nullptr, but if we are<br />
inside a QMainWindow we can use that as the parent. This ensures proper<br />
placement of the menus on wayland (where parents are required in order to<br />
have a transient parent window).</p>
<p>We also drop an old comment which claims popup menus should not have<br />
parent.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6045" rel="noreferrer">https://phabricator.kde.org/D6045</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kxmlgui_unittest.cpp<br />
autotests/kxmlgui_unittest.h<br />
src/kxmlguibuilder.cpp</div></div></div><br /><div><strong>To: </strong>elvisangelaccio, dfaure<br /><strong>Cc: </strong>Frameworks<br /></div>