<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5902" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5902#inline-24071" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">find_package</span><span class="p">(</span><span class="n">KF5NewStuffCore</span> <span class="n">NO_MODULE</span><span class="p">)</span> <span class="p">#</span> <span style="color: #aa4000">for</span> <span class="n">the</span> <span class="n">KNewStuffCore</span> <span class="n">library</span> <span class="n">only</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">find_package</span><span class="p">(</span><span class="n">KF5NewStuff</span> <span class="n">NO_MODULE</span><span class="p">)</span> <span class="p">#</span> <span style="color: #aa4000">for</span> <span class="n">the</span> <span class="n">KNewStuff</span> <span class="n">UI</span> <span class="n">library</span><span class="p">,</span> <span class="n">will</span> <span class="n">pull</span> <span style="color: #aa4000">in</span> <span class="n">KNewStuffCore</span> <span style="color: #aa4000">for</span> <span class="n">you</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd say that it looks better to have <tt style="background: #ebebeb; font-size: 13px;">CONFIG</tt> rather than <tt style="background: #ebebeb; font-size: 13px;">NO_MODULE</tt>. Both should work.</p>

<p style="padding: 0; margin: 8px;">Also <tt style="background: #ebebeb; font-size: 13px;">find_package(KF5 COMPONENTS NewStuffCore)</tt> reads better to my eye.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5902#inline-24072" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">(</span><span class="n">or</span> <span class="n">similar</span><span class="p">)</span> <span style="color: #aa4000">in</span> <span class="n">your</span> <span class="n">CMakeLists</span><span class="p">.</span><span class="n">txt</span> <span class="n">file</span><span class="p">,</span> <span class="n">and</span> <span class="n">you</span> <span class="n">need</span> <span class="n">to</span> <span class="n">link</span> <span class="n">to</span> <span class="n">KF5</span><span class="p">::</span><span class="n">NewStuff</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KF5</span><span class="p">::</span><span class="n">NewStuffCore</span> <span class="n">or</span> <span class="n">KF5</span><span class="p">::</span><span class="n">NewStuffQuick</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you ever need to link against <tt style="background: #ebebeb; font-size: 13px;">NewStuffQuick</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5902" rel="noreferrer">https://phabricator.kde.org/D5902</a></div></div><br /><div><strong>To: </strong>leinir, KNewStuff<br /><strong>Cc: </strong>apol, Frameworks<br /></div>