<table><tr><td style="">elvisangelaccio created this revision.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5877" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Either "." was explicitly added (in which case we use the absolute path<br />
of the cwd), or it's added as side effect of something else. For example<br />
in bug #374075 KIO adds ":/kio5/newfile-templates" as path to watch<br />
(this is probably another bug in itself) and this results in "." being<br />
passed as _path of addEntry().</p>
<p>If we are already watching "/home/user", this breaks the emission<br />
of the dirty() signal for every new children of "/home/user" (somehow,<br />
the relative path is used for them, e.g. "./foo.txt" instead of<br />
"/home/user/foo.txt"). In particular, in inotifyEventReceived()<br />
e->m_client is empty and so e->path is not added to<br />
e->m_pendingFileChanges.</p>
<p>Replacing "." with the absolute path fixes this issue.</p>
<p>BUG: 374075<br />
FIXED-IN: 5.35</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>From dolphin, Create New -> Text File in a folder which is also the current working<br />
directory of the dolphin process.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5877" rel="noreferrer">https://phabricator.kde.org/D5877</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kdirwatch_unittest.cpp<br />
src/lib/io/kdirwatch.cpp</div></div></div><br /><div><strong>To: </strong>elvisangelaccio, dfaure<br /><strong>Cc: </strong>Frameworks<br /></div>