<table><tr><td style="">intelfx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5802" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5802#109416" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D5802#109416</a>, <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mwolff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example for a color scheme where this would break stuff? Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all.</p></div>
</blockquote>
<p>OK — take a look at the attached screenshots (I hope Phabricator will preserve their names).</p>
<p><a href="https://phabricator.kde.org/F3752512" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752512: KDevelop-Vim (dark)-Before.png</a></p>
<p><a href="https://phabricator.kde.org/F3752511" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752511: KDevelop-Vim (dark)-After.png</a></p>
<p><a href="https://phabricator.kde.org/F3752510" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752510: KDevelop-Printing-Before.png</a></p>
<p><a href="https://phabricator.kde.org/F3752509" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752509: KDevelop-Printing-After.png</a></p>
<p><a href="https://phabricator.kde.org/F3752508" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752508: KDevelop-Normal-Before.png</a></p>
<p><a href="https://phabricator.kde.org/F3752507" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752507: KDevelop-Normal-After.png</a></p>
<p><a href="https://phabricator.kde.org/F3752506" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752506: KDevelop-KDE-Before.png</a></p>
<p><a href="https://phabricator.kde.org/F3752505" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752505: KDevelop-KDE-After.png</a></p>
<p><a href="https://phabricator.kde.org/F3752504" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752504: KDevelop-Breeze Dark-Before.png</a></p>
<p><a href="https://phabricator.kde.org/F3752503" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752503: KDevelop-Breeze Dark-After.png</a></p>
<p>So, basically, Normal and Printing are broken because they are explicitly designed for old behavior. Breeze-Dark and Vim-dark do not care because they have selection foreground == normal foreground.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, can you then share your solarized theme?</p></blockquote>
<p>Please find attached in form of rc files (append them to your kateschemarc/katesyntaxhighlightingrc, I've stripped all other color schemes).</p>
<p><a href="https://phabricator.kde.org/F3752527" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752527: katesyntaxhighlightingrc</a></p>
<p><a href="https://phabricator.kde.org/F3752526" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3752526: kateschemarc</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5802" rel="noreferrer">https://phabricator.kde.org/D5802</a></div></div><br /><div><strong>To: </strong>intelfx, KDevelop, KTextEditor, Kate<br /><strong>Cc: </strong>mwolff, kwrite-devel, Frameworks<br /></div>