<table><tr><td style="">mart created this revision.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5806" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Wayland requires menu windows to have a "transient parent" as wl_shell<br />
protocol refuses to either position correcty or assign the corrent<br />
flags to popup windows that don't have a parent.<br />
a lot of popup menus in KDE applications don't have any parent<br />
and will look wrong in wayland. this fixes at least some of the occurrences<br />
of popup menus build by kxmlgui</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>"Bookmarks" menu in konsole menubar is now correct in<br />
wayland</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>BRANCH</strong><div><div>phab/reparentmenus</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5806" rel="noreferrer">https://phabricator.kde.org/D5806</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kxmlguifactory_p.cpp</div></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>