<table><tr><td style="">intelfx created this revision.<br />Restricted Application added subscribers: Frameworks, kwrite-devel.<br />Restricted Application added a project: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5802" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This is not an actual pull-request but rather an RFC (request for comments) from<br />
the KTextEditor, Kate and KDevelop developers, because I failed to solicit any<br />
feedback on the kdevelop-devel@ and kwrite-devel@ mailing lists.</p>

<p>(<a href="http://kde.6490.n7.nabble.com/Properly-porting-Solarized-to-Kate-KDevelop-need-to-change-behavior-of-search-result-highlighting-td1655274.html" class="remarkup-link" target="_blank" rel="noreferrer">http://kde.6490.n7.nabble.com/Properly-porting-Solarized-to-Kate-KDevelop-need-to-change-behavior-of-search-result-highlighting-td1655274.html</a>)</p>

<p>So, I'm trying to make an exact port of Solarized to Kate/KDevelop and it looks<br />
like Solarized is not compatible with Kate's search result highlighting behavior:<br />
it requires search/replace highlight regions to use selection foreground and not<br />
the normal one. You can find the details in the linked archive post.</p>

<p>Moreover, seems like kdevplatform's context browser plugin hints at behavior<br />
sought by me (but implements it incorrectly).</p>

<p>(<a href="https://github.com/KDE/kdevplatform/blob/master/plugins/contextbrowser/contextbrowser.cpp#L657" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kdevplatform/blob/master/plugins/contextbrowser/contextbrowser.cpp#L657</a>)</p>

<p>However, just making that change will make Kate/KDevelop incompatible with all<br />
existing color schemes. Hence, how do I proceed?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>BRANCH</strong><div><div>selection-foreground-for-search-highlights</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5802" rel="noreferrer">https://phabricator.kde.org/D5802</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/search/katesearchbar.cpp<br />
src/view/kateview.cpp<br />
src/vimode/emulatedcommandbar/matchhighlighter.cpp</div></div></div><br /><div><strong>To: </strong>intelfx, KDevelop, KTextEditor, Kate<br /><strong>Cc: </strong>kwrite-devel, Frameworks<br /></div>