<table><tr><td style="">kfunk added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5766" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5766#inline-23524" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMGeneratePkgConfigFile.cmake:172</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">EGPF_INSTALL</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">NOT</span> <span style="color: #766510">CMAKE_SYSTEM_NAME</span> <span style="color: #766510">matches</span> <span style="color: #766510">"FreeBSD"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">ECM_PKGCONFIG_INSTALL_DIR</span> <span style="color: #766510">"${EGPF_LIB_INSTALL_DIR}/pkgconfig"</span> <span style="color: #766510">CACHE</span> <span style="color: #766510">PATH</span> <span style="color: #766510">"The directory where pkgconfig will be installed to."</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">matches</tt> -> <tt style="background: #ebebeb; font-size: 13px;">MATCHES</tt> -- I'm surprised that actually works as-is.</p>

<p style="padding: 0; margin: 8px;">Also: Why not <tt style="background: #ebebeb; font-size: 13px;">if (CMAKE_SYSTEM_NAME MATCHES ...)</tt> and switch the bodies inside the if & else branch to simplify?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5766" rel="noreferrer">https://phabricator.kde.org/D5766</a></div></div><br /><div><strong>To: </strong>tcberner, FreeBSD, apol<br /><strong>Cc: </strong>kfunk, Frameworks, Build System<br /></div>