<table><tr><td style="">kossebau accepted this revision.<br />kossebau added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3987" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#96434" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#96434</a>, <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#96418" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#96418</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#95858" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#95858</a>, <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Closing. This Diff refactored the code technically correct.</p></div>
</blockquote>
<p>Technically correct, as in: it builds.<br />
But semantically it is incorrect and a regression when it comes to flags, especially as high level languages are made for humans in the first line, not compilers ;)</p></div>
</blockquote>
<p>Not true, the patch does /not/ change behavior. See explanation in <a href="https://phabricator.kde.org/D3987#78426" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D3987#78426</a>.</p></div>
</blockquote>
<p>Na, I meant, for the human reader it is semantically incorrect to pass a (null) pointer as value for a set of bitflags :) Type mismatch in human brain :)<br />
(additional false brain alarm when one knows QFlags stores using an <tt style="background: #ebebeb; font-size: 13px;">int</tt>, which we learnt in school to not always have bitsize of pointer type)</p>
<p>(Personally I count that QFlags constructor hack for dealing with literal 0 values by that pointer-type overload an example of a hack blowing up with language changes,<br />
and now feeding nonsense stuff into the dependencies, next to bogus API dox in Qt itself, "zero must be a literal 0 value." when the default value shown right above is Q_NULLPTR, and compilers starting to complain about literal 0 being used (<a href="http://doc.qt.io/qt-5/qflags.html#QFlags-2" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qflags.html#QFlags-2</a>). And my bug filed got instantly bounced, API quality seems to be not a shared value among everyone... tss...</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>If you want to replace <tt style="background: #ebebeb; font-size: 13px;">MyFlags flags = nullptr</tt> by <tt style="background: #ebebeb; font-size: 13px;">... = {}</tt> please do so in a follow-up patch/review.</p></blockquote>
<p>Seems you do not see yourself in the duty to do the fix-up. so I have to scratch this itch myself, tss :)</p></blockquote>
<p>Yes, honestly I think either way is fine (<tt style="background: #ebebeb; font-size: 13px;">nullptr</tt> or <tt style="background: #ebebeb; font-size: 13px;">{}</tt>). Get... used to the new look I'd say ;)</p></blockquote>
<p>Eh, I am too old to add another code-reading exception to my stable brain, but too young yet to not stand up and fight non-sense ;) Also have I had to explain too many artifacts in code to too many beginners, so I rather invest my free time into sane code ;)</p>
<p>So will soon make contact with that clang-tidy then, openSUSE not having it as package invites me anyway to build/run from sources...</p>
<p>Revision hopefully now unlocked for closing by selecting "Accept Revision" action, too bad I could not convince you to improve this yourself :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R280 Prison</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3987" rel="noreferrer">https://phabricator.kde.org/D3987</a></div></div><br /><div><strong>To: </strong>kfunk, Frameworks, dfaure, kossebau<br /><strong>Cc: </strong>skelly, kossebau, dfaure, graesslin<br /></div>