<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5090" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5090#inline-20823" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprotocolmanager.cpp:844</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">useragent</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">KIO_VERSION_PATCH</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">useragent</span> <span style="color: #aa2211">+=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">" (like Gecko) <span class="bright">Konqueror</span>/"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">useragent</span> <span style="color: #aa2211">+=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">" (like Gecko) <span class="bright">kio_http</span>/"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">useragent</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">KIO_VERSION_MAJOR</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This may be techinically correct, but it's going to break stuff that uses user agent detection (yes i know, that's broken but people use it still), so -1</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5090" rel="noreferrer">https://phabricator.kde.org/D5090</a></div></div><br /><div><strong>To: </strong>ltoscano, dfaure<br /><strong>Cc: </strong>aacid, lueck, Frameworks<br /></div>