<table><tr><td style="">mck182 added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4799" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch! I wanted to do exactly this a long<br />
time ago. However this solution brings a burden to all<br />
apps using KNotification in form of a blocking dbus call<br />
which is further only relevant when used in Plasma.</p>
<p>That's a no-no I'm afraid, we'd have to find a better solution.</p>
<p>I was thinking that maybe KSplash should have the notifications<br />
dbus interface instead and handle it somehow on its own,<br />
either just collecting the notifications and then reemitting them<br />
once it's done splashing, or just displaying them directly, I dunno.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19290" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager.cpp:140</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">blockNotifications</span> <span style="color: #aa2211">=</span> <span class="n">sessionBus</span><span class="p">.</span><span class="n">interface</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">isServiceRegistered</span><span class="p">(</span><span style="color: #766510">"org.kde.KSplash"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">blockNotifications</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The problem with this is that <tt style="background: #ebebeb; font-size: 13px;">isServiceRegistered</tt> is<br />
a blocking call. Blocking dbus calls are generally a nogo<br />
because it can happen that it will get stuck in dbus<br />
timeout, which is 25 secs by default. And that's bad.<br />
Especially because this would be blocking the hosting<br />
app.</p>
<p style="padding: 0; margin: 8px;">Generally any dbus blocking calls are bad.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19291" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager.cpp:143</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">qCDebug</span><span class="p">(</span><span class="n">LOG_KNOTIFICATIONS</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Splash is in progress, delaying notifications"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QDBusServiceWatcher</span><span style="color: #aa2211">*</span> <span class="n">watcher</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QDBusServiceWatcher</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">watcher</span><span style="color: #aa2211">-></span><span class="n">setConnection</span><span class="p">(</span><span class="n">sessionBus</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The coding style of frameworks is <tt style="background: #ebebeb; font-size: 13px;"> *watcher</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19292" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager.cpp:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">watcher</span><span style="color: #aa2211">-></span><span class="n">setWatchMode</span><span class="p">(</span><span class="n">QDBusServiceWatcher</span><span style="color: #aa2211">::</span><span class="n">WatchForUnregistration</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">connect</span><span class="p">(</span><span class="n">watcher</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">serviceUnregistered</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">)),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">renotify</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We use the new signals/slots style in frameworks</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19293" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager.cpp:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #aa4000">void</span> <span class="n">KNotificationManager</span><span style="color: #aa2211">::</span><span class="n">renotify</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">serv</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">renotify</tt> is not entirely ideal name; something like<br />
<tt style="background: #ebebeb; font-size: 13px;">processQueue</tt> would be much more fitting.</p>
<p style="padding: 0; margin: 8px;">Also, coding style is <tt style="background: #ebebeb; font-size: 13px;"> &serv</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19295" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager.cpp:275</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">Q_FOREACH</span> <span class="p">(</span><span class="n">KNotification</span><span style="color: #aa2211">*</span> <span class="n">n</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">notifications</span><span class="p">.</span><span class="n">values</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">notify</span><span class="p">(</span><span class="n">n</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style is <tt style="background: #ebebeb; font-size: 13px;"> *n</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4799#inline-19294" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knotificationmanager_p.h:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">void</span> <span style="color: #004012">reparseConfiguration</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">app</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">void</span> <span style="color: #004012">renotify</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style is <tt style="background: #ebebeb; font-size: 13px;">&</tt> with the var name, also always<br />
put the variable name in the header and use Q_UNUSED<br />
in the implementation.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4799" rel="noreferrer">https://phabricator.kde.org/D4799</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>vpilo<br /><strong>Cc: </strong>mck182, Frameworks<br /></div>