<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4707" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4707#inline-19217" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">framesvg.cpp:804</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QLatin1Char</span> <span style="color: #004012">s</span><span class="p">(</span><span style="color: #766510">'_'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">return</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">frame</span><span style="color: #aa2211">-></span><span class="n">enabledBorders</span><span class="p">)</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">size</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">size</span><span class="p">.</span><span class="n">height</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">scaleFactor</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatio</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">prefixToSave</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="bright"></span><span class="n"><span class="bright">q</span></span><span style="color: #aa2211">-></span><span class="n">imagePath<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">return</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">frame</span><span style="color: #aa2211">-></span><span class="n">enabledBorders</span><span class="p">)</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">size</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">size</span><span class="p">.</span><span class="n">height</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">scaleFactor</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatio</span><span class="p">())</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="n">prefixToSave</span> <span style="color: #aa2211">%</span> <span class="n">s</span> <span style="color: #aa2211">%</span> <span class="bright"></span><span class="n"><span class="bright">frame</span></span><span style="color: #aa2211">-></span><span class="n">imagePath</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't understand this and the FrameData part of this change.</p>

<p style="padding: 0; margin: 8px;">q->imagePath() will still always be correct as before, you still set that in setImagePath() regardless of whether we are blocking updates or not.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4707" rel="noreferrer">https://phabricator.kde.org/D4707</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>