<table><tr><td style="">davidedmundson created this revision.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4729" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Unlike the visible property, the opacity does not inherit parent values<br />
and refers to the relative opacity of that item.</p>

<p>The current style code is checking that an item we can't control<br />
externally has an opacity > 0, this doesn't really acheive anything.</p>

<p>This was a breakage from when we ported *to* QtQuickControls 1.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I was running a plasmoid I had written years ago (my RSS tutorial)<br />
and had abnormally high CPU usage in an animation that I didn't have then.</p>

<p>Code was:</p>

<p>BusyIndicator {<br />
opacity: 0<br />
running: true<br />
}</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4729" rel="noreferrer">https://phabricator.kde.org/D4729</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>