<table><tr><td style="">mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4584" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4584#inline-18192" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdirwatch.cpp:371</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                                <span style="color: #74777d">// files in WatchFiles mode with inotify.</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">isDir</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                    <span class="n">addEntry</span><span class="p">(</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">instance</span><span class="p">,</span> <span class="n">tpath</span><span class="p">,</span> <span style="color: #aa4000">nullptr</span><span class="p">,</span> <span class="n">isDir</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">future patch should hoist that out of the loop to not rely on the compiler to do our job</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4584#inline-18191" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdirwatch_p.h:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #74777d">// (even though the vector of clients is empty at that point, so no performance penalty there)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #74777d">//Client(const Client &) = delete;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #74777d">//Client &operator=(const Client &) = delete;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">instead of commenting it out, =default them?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4584#inline-18193" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdirwatch_p.h:141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">Client</span> <span style="color: #aa2211">*></span> <span class="n">clientsForFileOrDir</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">tpath</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span style="color: #aa2211">*</span><span class="n">isDir</span><span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">Client</span> <span style="color: #aa2211">*></span> <span class="n">inotifyClientsForFileOrDir</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">isDir</span><span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">QList</span><span style="color: #aa2211"><<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">Client</span> <span style="color: #aa2211">*></span> <span class="n">clientsForFileOrDir</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">tpath</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span style="color: #aa2211">*</span><span class="n">isDir</span><span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">QList</span><span style="color: #aa2211"><<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">Client</span> <span style="color: #aa2211">*></span> <span class="n">inotifyClientsForFileOrDir</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">isDir</span><span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">so.. the client is copyable, no? If so, returning a vector<Client> here as well would be much nicer, no?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4584" rel="noreferrer">https://phabricator.kde.org/D4584</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>dfaure, aacid, mpyne<br /><strong>Cc: </strong>mwolff, Frameworks<br /></div>