<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4556" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Just because the metadata is invalid doesn't mean the DataEngine<br />
actually failed to load, we're still returning a valid object, and as<br />
seen with the MPris DataEngine bug. It's important that we still release<br />
it properly.</p>

<p>It looks like this was designed to make sure you don't delete the null<br />
data engine multiple times, but that shouldn't cause an issue here.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/tag/plasma/" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">#plasma</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4556" rel="noreferrer">https://phabricator.kde.org/D4556</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/plasma/dataengine.cpp<br />
src/plasma/dataengineconsumer.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>