<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4508" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Skimmed through it until <tt style="background: #ebebeb; font-size: 13px;">ItemDelegate.qml</tt>, few nitpicks for that below</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17922" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BusyIndicator.qml:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">implicitWidth:</span> <span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">implicitWidth</span> <span style="color: #aa2211">+</span> <span style="color: #004012">leftPadding</span> <span style="color: #aa2211">+</span> <span style="color: #004012">rightPadding</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">implicitHeight:</span> <span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">implicitHeight</span> <span style="color: #aa2211">+</span> <span style="color: #004012">topPadding</span> <span style="color: #aa2211">+</span> <span style="color: #004012">bottomPadding</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Apparently in Qt 5.8 the implicit sizes now take into account padding but since we want to support 5.7 (?) makes sense.</p>
<p style="padding: 0; margin: 8px;">Mentioned in the changelog: <a href="https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/dist/changes-5.8.0" class="remarkup-link" target="_blank" rel="noreferrer">https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/dist/changes-5.8.0</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17923" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BusyIndicator.qml:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">anchors.centerIn:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">width:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You sure this doesn't break anything if you mess with anchors and sizes and don't have a wrapper <tt style="background: #ebebeb; font-size: 13px;">Item</tt> around it?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17924" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BusyIndicator.qml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">height:</span> <span style="color: #004012">width</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">smooth:</span> <span style="color: #aa2211">!</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">running</span> <span style="color: #aa2211">||</span> <span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">hasOwnProperty</span><span class="p">(</span><span style="color: #766510">"smoothAnimation"</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">smoothAnimation</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think with QtQuick 2 <tt style="background: #ebebeb; font-size: 13px;">smooth</tt> doesn't matter anymore, other than making it look worse.</p>
<p style="padding: 0; margin: 8px;">From docs</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">In Qt Quick 2.0, this property has minimal impact on performance.</p></blockquote></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17925" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Button.qml:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">hoverEnabled:</span> <span style="color: #000a65">true</span> <span style="color: #74777d">//Qt.styleHints.useHoverEffects TODO: how to make this work in 5.7?</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Docs say</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">You can also enable or disable hover effects for all Qt Quick Controls 2 applications by setting the QT_QUICK_CONTROLS_HOVER_ENABLED environment variable.</p></blockquote></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17926" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Button.qml:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">contentItem:</span> <span style="color: #004012">Label</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">text:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">text</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What <tt style="background: #ebebeb; font-size: 13px;">Label</tt> is this? I don't see any import/namespace that would provide this here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17927" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Button.qml:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">text:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">text</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">font:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">font</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">opacity:</span> <span style="color: #004012">enabled</span> <span style="color: #aa2211">||</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">highlighted</span> <span style="color: #aa2211">||</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">checked</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0.4</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QQC2 <tt style="background: #ebebeb; font-size: 13px;">Label</tt> supposedly supports <tt style="background: #ebebeb; font-size: 13px;">font</tt> (and probably other) inheritance</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17930" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CheckIndicator.qml:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">anchors.fill:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">state:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">activeFocus</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"focus"</span> <span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">hovered</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"hover"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"shadow"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Now that we have <tt style="background: #ebebeb; font-size: 13px;">activeFocusReason</tt> we could potentially behave differently whether it was user-focused or tab-focused (not now but keeping that in mind for the future)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17931" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ComboBox.qml:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">popup:</span> <span style="color: #004012">T</span><span class="p">.</span><span style="color: #004012">Popup</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">y:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">height</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">in-window <tt style="background: #ebebeb; font-size: 13px;">Popup</tt> makes me sad :(</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17932" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DialogButtonBox.qml:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">contentItem:</span> <span style="color: #004012">ListView</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">implicitWidth:</span> <span style="color: #004012">contentWidth</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do we really want a <tt style="background: #ebebeb; font-size: 13px;">ListView</tt> here?</p>
<p style="padding: 0; margin: 8px;">Also, how does it work with e.g. <tt style="background: #ebebeb; font-size: 13px;">HelpRole</tt> and things that would go on the left rather than the right? Dunno if it supports that though</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17933" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Drawer.qml:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">topPadding:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">edge</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">BottomEdge</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">leftPadding:</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">edge</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">RightEdge</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">Math.round(units.devicePixelRatio)</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">1</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17934" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Frame.qml:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">padding:</span> <span style="color: #601200">6</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoded number</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4508" rel="noreferrer">https://phabricator.kde.org/D4508</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>