<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, graesslin, dfaure.<br />broulik set the repository for this revision to R295 KCMUtils.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4493" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This disconnects the connection when the window goes away otherwise it might crash.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Fixes kwin effects kcm crashing in System Settings with <a href="https://phabricator.kde.org/D4492" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4492</a> where that signal is actually emitted.<br />
The effects KCM doesn't really update its colors but I think that is because the kwin effects kcm doesn't use SystemPalette but takes care of the colors manually</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R295 KCMUtils</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4493" rel="noreferrer">https://phabricator.kde.org/D4493</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kcmoduleqml.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, graesslin, dfaure<br /><strong>Cc: </strong>plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>