<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129798/">https://git.reviewboard.kde.org/r/129798/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should I move the review request to phabricator ?</p></pre>
<br />
<p>- Matthieu Gallien</p>
<br />
<p>On January 15th, 2017, 4:03 p.m. CET, Matthieu Gallien wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Baloo and KDE Frameworks.</div>
<div>By Matthieu Gallien.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2017, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Musepack extraction of album artist was using the wrong tag name (tested
against easytag and picard).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that APE is using "ALBUM ARTIST" with a space between both words.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/samplefiles/test.flac <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.m4a <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.mp3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.mpc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.ogg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/taglibextractortest.cpp <span style="color: grey">(d46e49e)</span></li>
<li>src/extractors/taglibextractor.cpp <span style="color: grey">(8fcad93)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129798/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>