<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3987" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#78427" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#78427</a>, <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#78420" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#78420</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3987#78383" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3987#78383</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I agree. But it's the default value anyway, so why not remove it completely, thus making everyone happy?</p></div>
</blockquote>
<p>What do you mean by "remove"? In the samples from a few comments above, the <tt style="background: #ebebeb; font-size: 13px;">0</tt> (or now <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt>) is used as (default) value for an argument:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">+ NETWinInfo info(QX11Info::connection(), win, QX11Info::appRootWindow(), nullptr, nullptr);
+ explicit KProgressDialog(QWidget *parent = nullptr, const QString &caption = QString(),
+ const QString &text = QString(), Qt::WindowFlags flags = nullptr);
+ QCOMPARE(QStringList(queryUrl.queryItems(nullptr).keys()).join(", "),
+ KLocale::TimeFormatOptions timeOptions = nullptr,</pre></div>
<p>How could that be removed here? Unless you mean replacing with the default constructor of the flags type? That might be even better for human readers at least, agreed :) Though not sure how easy that fix-up is, but maybe the clang artist knows what to do?</p></div>
</blockquote>
<p><tt style="background: #ebebeb; font-size: 13px;">Qt::WindowFlags flags = {}</tt>, or<br />
<tt style="background: #ebebeb; font-size: 13px;">Qt::WindowFlags flags = Qt::WindowFlags()</tt></p></div>
</blockquote>
<p>"What to do" was about how to create a diff automatically :)</p>
<p>Have to say, personally I am used to the <tt style="background: #ebebeb; font-size: 13px;">0</tt> to denote a bitmask without any bit set, and would assume quite some other people as well. Not sure if <tt style="background: #ebebeb; font-size: 13px;">{}</tt> would be an improvement for the human reader, being another pattern to learn.</p>
<p>But assuming we want to avoid <tt style="background: #ebebeb; font-size: 13px;">0</tt> as value for QFlags-based types, when comparing</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">NETWinInfo info(QX11Info::connection(), win, QX11Info::appRootWindow(), {}, {});
explicit KProgressDialog(QWidget *parent = nullptr, const QString &caption = QString(),
const QString &text = QString(), Qt::WindowFlags flags = {});
QCOMPARE(QStringList(queryUrl.queryItems({}).keys()).join(", "),
KLocale::TimeFormatOptions timeOptions = {},</pre></div>
<p>with</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">NETWinInfo info(QX11Info::connection(), win, QX11Info::appRootWindow(), NET::Properties(), NET::Properties2());
explicit KProgressDialog(QWidget *parent = nullptr, const QString &caption = QString(),
const QString &text = QString(), Qt::WindowFlags flags = Qt::WindowFlags());
QCOMPARE(QStringList(queryUrl.queryItems(KUrl::QueryItemsOptions()).keys()).join(", "),
KLocale::TimeFormatOptions timeOptions = KLocale::TimeFormatOptions(),</pre></div>
<p>it might be nice to use <tt style="background: #ebebeb; font-size: 13px;">{}</tt> for default values, as the type is given already, and the explicit constructor for arguments when calling methods, as it adds information in the code itself.</p>
<p>My 2 cents. In the end I was okay with <tt style="background: #ebebeb; font-size: 13px;">0</tt>, just am unhappy with <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt> being used for QFlags values, for the reasons given :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R280 Prison</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3987" rel="noreferrer">https://phabricator.kde.org/D3987</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, Frameworks, dfaure, kossebau<br /><strong>Cc: </strong>kossebau, dfaure, graesslin<br /></div>