<table><tr><td style="">albertvaka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4142" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4142#77834" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4142#77834</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Care needs to be taken that existing notifications don't suddenly behave differently but that moving from actions() to defaultAction() is a conscious and explicit choice in the application that emits the notification.</p></div>
</blockquote>
<p>I've already made sure that existing apps behave as they currently do. Even more: apps that decide to move from setActions to setDefaultAction will still display exactly the same way in Plasma, with an action button (until/unless we change the Plasmoid to honor the default action, which we can discuss when I submit the patch for the Plasmoid).</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4142#77832" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4142#77832</a>, <a href="https://phabricator.kde.org/p/mart/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mart</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>code wise the change makes sense..<br />
that said, this assumes we do an important behavior change in our ui, which i don't think is a good thing, as is disregards completely how our users are used to, in the name of "other platforms do things differently".</p></div>
</blockquote>
<p>No, there is no change in our UI at all. In Plasma and KDE apps we can decide to never use this feature if we think that the UX is better that way, but IMO this is a generic (not Plasma-specific) framework and it should provide access to the functionality anyway. This is a really common use case for notifications on most platforms, so if we want that some day this framework can be useful on, for example, Android or Gnome, this is something we have to provide. I think that it would be good to adopt it on Plasma and KDE apps, but this is a completely different discussion that we can have on the mailing list.</p>
<p>And no, I don't think that our users will freak out if we start behaving like every other notification system.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4142#77861" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4142#77861</a>, <a href="https://phabricator.kde.org/p/colomar/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@colomar</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hm, that's not easy to decide. Whether one likes the "click to make go away" behavior or not is highly subjective. I, for one, find it very annoying on e.g. OS when a notification covers something I want to see on the screen and there is no way to make it go away other than waiting. Others find it annoying to have to explicitly click a button to execute the default action.</p></div>
</blockquote>
<p>Same thing: the framework giving access to this feature doesn't mean your app has to use it. Even more: it doesn't even change the behaviour in Plasma! In Plasma the default action will still appear as a button unless we change the plasmoid. This will, however, make it possible to use this feature on desktops that do support default actions.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4142" rel="noreferrer">https://phabricator.kde.org/D4142</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>albertvaka, Frameworks, VDG<br /><strong>Cc: </strong>colomar, broulik, mart, Frameworks<br /></div>