<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4130" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I see a problem with this patch, it seems it breaks custom widgets that are using properties <em>without</em> a <tt style="background: #ebebeb; font-size: 13px;">NOTIFY</tt> signal.</p>

<p>In Ark we are using a plain QTreeWidget in the config dialog, and we have the following code:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #74777d">// Set the custom property that KConfigDialogManager will use to update the settings.</span>
<span class="n">kcfg_disabledPlugins</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"kcfg_property"</span><span class="p">,</span> <span class="n">QByteArray</span><span class="p">(</span><span style="color: #766510">"disabledPlugins"</span><span class="p">));</span>
<span style="color: #74777d">// Tell KConfigDialogManager to monitor the itemChanged signal for a QTreeWidget instance in the dialog.</span>
<span class="n">KConfigDialogManager</span><span style="color: #aa2211">::</span><span class="n">changedMap</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">insert</span><span class="p">(</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span class="n">QTreeWidget</span><span style="color: #aa2211">::</span><span class="n">staticMetaObject</span><span class="p">.</span><span class="n">className</span><span class="p">()),</span>
                                           <span class="n">SIGNAL</span><span class="p">(</span><span class="n">itemChanged</span><span class="p">(</span><span class="n">QTreeWidgetItem</span><span style="color: #aa2211">*</span><span class="p">,</span><span style="color: #aa4000">int</span><span class="p">)));</span></pre></div>

<p>If I remove the <tt style="background: #ebebeb; font-size: 13px;">changedMap()</tt> line in ark and apply your patch, the Apply button in the config dialog is no longer enabled whenever the items in the QTreeWidget change.</p>

<p>This could be solved by subclassing QTreeWidget, but that would be annoying :p</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4130" rel="noreferrer">https://phabricator.kde.org/D4130</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, Frameworks<br /><strong>Cc: </strong>elvisangelaccio<br /></div>