<table><tr><td style="">aspotashev added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4023" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4023#inline-15899" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformatprivate.cpp:381</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span class="n"><span class="bright">tr</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Last %1"</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">arg</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_locale</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">dayName</span></span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()<span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">format</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">switch</span></span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">case</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span class="n">tr</span><span class="p">(</span><span style="color: #766510">"Last Monday"</span><span class="p">,</span>    <span style="color: #766510">"day in the previous week"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs a space: "switch ("</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4023#inline-15901" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformatprivate.cpp:382</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span class="n"><span class="bright">tr</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Last %1"</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">arg</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_locale</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">dayName</span></span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()<span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">format</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">switch</span></span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">case</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span class="n">tr</span><span class="p">(</span><span style="color: #766510">"Last Monday"</span><span class="p">,</span>    <span style="color: #766510">"day in the previous week"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">case</span> <span style="color: #601200">2</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span class="n">tr</span><span class="p">(</span><span style="color: #766510">"Last Tuesday"</span><span class="p">,</span>   <span style="color: #766510">"day in the previous week"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indentation of "case " lines is probably against the coding style.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4023#inline-15900" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformatprivate.cpp:400</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">case</span> <span style="color: #601200">7</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span class="n">tr</span><span class="p">(</span><span style="color: #766510">"Next Sunday"</span><span class="p">,</span>    <span style="color: #766510">"day in the week after this"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="http://doc.qt.io/qt-5/qdate.html#dayOfWeek" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qdate.html#dayOfWeek</a> says "Returns 0 if the date is invalid". What happens when the input date is invalid?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4023" rel="noreferrer">https://phabricator.kde.org/D4023</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mpyne, Frameworks, kde-i18n-doc, aspotashev<br /></div>