<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a reviewer: dhaumann.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4003" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Two thinkgs:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Please address the comments from Christoph and myself</li>
<li class="remarkup-list-item">Please adapt in kate.git: kate/docs/</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4003#inline-15837" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedocument.cpp:4587</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">var</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"bom"</span><span class="p">)</span> <span style="color: #aa2211">||</span> <span class="n">var</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"byte-order-marker"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #74777d">// TODO: byte-order-marker is misnomer, should be byte-order-mark</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">checkBoolValue</span><span class="p">(</span><span class="n">val</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">state</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, please add backwards compatibility:</p>

<p style="padding: 0; margin: 8px;">} else if (var == QLatin1String("bom") || var == QLatin1String("byte-order-mark") || var == QLatin1String("byte-order-marker")) {</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4003#inline-15838" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">variablelineedit.cpp:162</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// Add 'byte-order-marker' (bom) to list</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">VariableBoolItem</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"byte-order-marker"</span><span class="p">),</span> <span class="n">docConfig</span><span style="color: #aa2211">-></span><span class="n">bom</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">rename comment to "byte-order-mark"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4003#inline-15839" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">variablelineedit.cpp:163</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// Add 'byte-order-marker' (bom) to list</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">VariableBoolItem</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"byte-order-marker"</span><span class="p">),</span> <span class="n">docConfig</span><span style="color: #aa2211">-></span><span class="n">bom</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setHelpText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"short translation please"</span><span class="p">,</span> <span style="color: #766510">"Enable the byte order mark<span class="bright">er</span> when saving <span class="bright">u</span>nicode files."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">setHelpText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"short translation please"</span><span class="p">,</span> <span style="color: #766510">"Enable the byte order mark<span class="bright"> (BOM)</span> when saving <span class="bright">U</span>nicode files."</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rename to "byte-order-mark"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>BRANCH</strong><div><div>alignNamingOfBOFandUnicode</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4003" rel="noreferrer">https://phabricator.kde.org/D4003</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, Kate, dhaumann<br /><strong>Cc: </strong>dhaumann, cullmann, kwrite-devel, Frameworks<br /></div>