<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />broulik set the repository for this revision to R242 Plasma Frameworks.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4012" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Every single (Frame)SvgItem would creates its own Units instance which in turn would create a property map for icon sizes and lots of other stuff. Avoid this.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I no longer get a tonne of Units objects created</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Frameworks</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4012" rel="noreferrer">https://phabricator.kde.org/D4012</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/core/corebindingsplugin.cpp<br />
src/declarativeimports/core/framesvgitem.cpp<br />
src/declarativeimports/core/framesvgitem.h<br />
src/declarativeimports/core/svgitem.cpp<br />
src/declarativeimports/core/svgitem.h<br />
src/declarativeimports/core/units.cpp<br />
src/declarativeimports/core/units.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas<br /></div>