<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129709/">https://git.reviewboard.kde.org/r/129709/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129709/diff/3/?file=488204#file488204line58" style="color: black; font-weight: bold; text-decoration: underline;">src/kdatecombobox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="nf">isValid</span><span class="p">(</span><span class="k">const</span> <span class="n">QDate</span> <span class="o">&</span><span class="n">date</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please add a short comment what this function does? A condition like
!date.isValid() || isValid(date)
looks confusing without some explanation.</pre>
</div>
</div>
<br />
<p>- Christoph Feck</p>
<br />
<p>On December 28th, 2016, 6:49 p.m. CET, David Jarvie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2016, 6:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checks to determine whether an entered date is valid are wrong or missing in various places in the code. This is due to:
- not testing if a minimum or maximum date is set before comparing a date to the minimum/maximum;
- always rejecting new minimum/maximum dates if the other maximum/minimum date is not set;
- not testing dates for validity when set by the date picker or menu.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This results in the following bugs currently:
- When an up/down arrow or page up/down key is pressed to change the date, and the minimum and maximum dates are not set, it is always considered invalid and the date is not changed.
- When the DateKeywords option is set, and the minimum and maximum dates are not set, the only date which is displayed in the menu is "No Date".
- setMinimumDate() and resetMinimumDate() do nothing if no maximum date is currently set.
- setMaximumDate() and resetMaximumDate() do nothing if no minimum date is currently set.
- resetDateRange() does nothing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes the above bugs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Documentation comments in the header file are also improved.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Updated autotests pass. GUI changes tested with KAlarm, including setting DateKeywords. The bugs described above are now fixed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kdatecomboboxtest.cpp <span style="color: grey">(c15525a)</span></li>
<li>src/kdatecombobox.h <span style="color: grey">(d9a20ca)</span></li>
<li>src/kdatecombobox.cpp <span style="color: grey">(ad1d085)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129709/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>