<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129394/">https://git.reviewboard.kde.org/r/129394/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129394/diff/2/?file=487091#file487091line113" style="color: black; font-weight: bold; text-decoration: underline;">filenamesearch/kio_filenamesearch.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">104</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">entry</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">KIO</span><span class="o">::</span><span class="n">UDSEntry</span><span class="o">::</span><span class="n">UDS_URL</span><span class="p">,</span> <span class="n">item</span><span class="p">.</span><span class="n">url</span><span class="p">().</span><span class="n">url</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">113</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">name</span> <span class="o">=</span> <span class="n">item</span><span class="p">.</span><span class="n">name</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or we must keep KIO::UDSEntry::UDS_URL in new patch ?</p></pre>
</div>
</div>
<br />
<p>- Anthony Fieroni</p>
<br />
<p>On Декември 5th, 2016, 10:04 след обяд EET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel Pescosta.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Дек. 5, 2016, 10:04 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug is introduced in https://git.reviewboard.kde.org/r/129297/
When is fixed new kio-extras realease is needed for 16.08 branch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No big ram usage but still not works as expected.
1. Perform search in Dolphin
2. Delete one result item
3. View must be update, but it's not</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filenamesearch/CMakeLists.txt <span style="color: grey">(774d79e)</span></li>
<li>filenamesearch/filenamesearchdbusinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filenamesearch/filenamesearchdbusinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filenamesearch/kded/CMakeLists.txt <span style="color: grey">(48160ed)</span></li>
<li>filenamesearch/kded/filenamesearchdbusadaptor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filenamesearch/kded/filenamesearchdbusadaptor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filenamesearch/kded/filenamesearchmodule.h <span style="color: grey">(4fa6bb1)</span></li>
<li>filenamesearch/kded/filenamesearchmodule.cpp <span style="color: grey">(f12626d)</span></li>
<li>filenamesearch/kio_filenamesearch.h <span style="color: grey">(0920394)</span></li>
<li>filenamesearch/kio_filenamesearch.cpp <span style="color: grey">(f124f02)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129394/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>