<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129625/">https://git.reviewboard.kde.org/r/129625/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Faure</p>
<br />
<p>On December 8th, 2016, 10:50 a.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2016, 10:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is an attempt to fix this ugly error message: http://i.imgur.com/26Y6Xix.png
The problem is that in KIO::buildErrorString() the ERR_CANNOT_LAUNCH_PROCESS case assumes that the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">errorText</code> starts with the name of a process (example usage in <a href="https://lxr.kde.org/source/kde/kdenetwork/kio-extras/smb/kio_smb_mount.cpp#0110" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kio_smb</a>). However, Slave::createSlave() also uses ERR_CANNOT_LAUNCH_PROCESS but with "self-contained" error messages, which results in the unfortunate screenshot above.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is no easy way to fix this without breaking the error messages from the client slaves, so I propose to add a new error code ERR_CANNOT_CREATE_SLAVE which is used only by Slave::createSlave() (at least for now).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See screenshots before/after.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/global.h <span style="color: grey">(3d38436fbe28f4236b6ca34a651c1805295c02f2)</span></li>
<li>src/core/job_error.cpp <span style="color: grey">(a67954cc44be6994992167700315321761ce0528)</span></li>
<li>src/core/slave.cpp <span style="color: grey">(4690ed50d3f5d28bdaeee84f85107ab75cfab555)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129625/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/a4a6468a-0376-4979-9af0-8a11229acf69__26Y6Xix.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/b534602e-39eb-44bf-915d-046110ed0e78__Screenshot_20161207_194933.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>