<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129617/">https://git.reviewboard.kde.org/r/129617/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Jonathan Marten.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is currently built and installed, but it is not usable because it needed to be converted to the new plugin system. Trying to use the viewer gives the standard Qt message "Failed to extract plugin meta data...".
This change uses kservice_desktop_to_json and K_PLUGIN_FACTORY_WITH_JSON to embed the plugin data as is now required, eliminating the KHTMLImageFactory.
Yes, the viewer is primitive... but is ought to be made to work as part of a basic installation, as it is the only image viewer part available if nether gwenview nor okular is installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built khtml with this change, checked operation of the embedded viewer part in Konqueror and other applications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(99b6ce6e)</span></li>
<li>src/khtmlimage.cpp <span style="color: grey">(2f1efe11)</span></li>
<li>src/khtmlimage.desktop <span style="color: grey">(00ccd72a)</span></li>
<li>src/khtmlimage.h <span style="color: grey">(eaaf5c76)</span></li>
<li>src/khtmlimage_init.cpp <span style="color: grey">(ff93bb4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129617/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>