<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129341/">https://git.reviewboard.kde.org/r/129341/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks OK. It would have been better to make this two separate commits though (one about shared_ptr and one about the #define, they are completely unrelated).</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On November 15th, 2016, 8:54 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2016, 8:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runtime/kwalletd/CMakeLists.txt <span style="color: grey">(5092a7e77a1ca7203827e444c11310566b2cc8b5)</span></li>
<li>src/runtime/kwalletd/backend/CMakeLists.txt <span style="color: grey">(2f99bc3cca89dd7a194f46cb314d2f7f90f931f3)</span></li>
<li>src/runtime/kwalletd/backend/backendpersisthandler.h <span style="color: grey">(a6682353d62fd63e88a0de6277801c624c794c74)</span></li>
<li>src/runtime/kwalletd/backend/backendpersisthandler.cpp <span style="color: grey">(413d4cd23ef1e15b75cd366061f07f179241af58)</span></li>
<li>src/runtime/kwalletd/backend/kwalletbackend.h <span style="color: grey">(4811a58e942685b01ed097ef15c2838e3833865c)</span></li>
<li>src/runtime/kwalletd/backend/kwalletbackend.cc <span style="color: grey">(43f30a545d36b64b102c794de3625621a694983e)</span></li>
<li>src/runtime/kwalletd/knewwalletdialog.h <span style="color: grey">(ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d)</span></li>
<li>src/runtime/kwalletd/knewwalletdialog.cpp <span style="color: grey">(0d9ffb8ed469536cee9d4055ac0bd001fff115a0)</span></li>
<li>src/runtime/kwalletd/kwalletd.cpp <span style="color: grey">(ca7d4ffbdff4178878b3c705921ef2b1970e0dbd)</span></li>
<li>src/runtime/kwalletd/kwalletwizard.h <span style="color: grey">(4cf8de424af800716e7c779d6d419eae4b54e426)</span></li>
<li>src/runtime/kwalletd/kwalletwizard.cpp <span style="color: grey">(cd52e54a668554fc0e14f4ad4cb29ba6f27fd330)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129341/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>