<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129405/">https://git.reviewboard.kde.org/r/129405/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129405/diff/1/?file=485458#file485458line47" style="color: black; font-weight: bold; text-decoration: underline;">src/kcollapsiblegroupbox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span class="o"><</span><span class="n">QWidget</span><span class="o">*</span><span class="p">,</span> <span class="kt">int</span><span class="o">></span> <span class="n">focusMap</span><span class="p">;</span> <span class="c1">// Used to restore focus policy of widgets.</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why int and not Qt::FocusPolicy?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it'll save you casting later.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On November 15th, 2016, 11:06 a.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Edmundson.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2016, 11:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because the groupbox hides all chidren on collapse event and shows them on expand event.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The rationale was explained in this comment: "when collapsed hide contents to save resources and more importantly get it out the focus chain"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The focus chain problem can be solved by overriding/restoring the focus policy of children widgets, without changing their visibility.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test app has been expanded with an hidden checkbox</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Make sure the new checkbox stays hidden after expanding the groupbox.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">With both groups collapsed, make sure the tab-focus goes from the first group to the second one (skipping the 7 checkboxes in the first group).</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kcollapsiblegroupbox_test.h <span style="color: grey">(b7f538217f480ea48bc28f098c7968fe21dda676)</span></li>
<li>autotests/kcollapsiblegroupbox_test.cpp <span style="color: grey">(4c458c4f700e498c178a637c29d6cc78ab8c267c)</span></li>
<li>src/kcollapsiblegroupbox.cpp <span style="color: grey">(273110e995cb25f28a815cb28125c4678ca2ab28)</span></li>
<li>tests/kcollapsiblegroupboxtest.cpp <span style="color: grey">(5a2900e63e42fa81f909c7d1fff0d07033edb025)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129405/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png">Before: hidden checkbox is visible</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png">After: hidden checkbox is hidden</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>