<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129327/">https://git.reviewboard.kde.org/r/129327/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2016, 6:08 p.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's weird that it's called <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">desktopFileName</code> but it doesn't offer a file name? I think it should be renamed or fixed to provide the path. In the end it's an API that then requires the user to do a rather big look-up.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The naming follows the naming in: NETWinInfo, KAboutData and QGuiApplication. Naming it differently would be wrong IMHO.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On November 7th, 2016, 7:29 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Eike Hein.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2016, 7:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change introduced a new method in KWindowInfo:
QByteArray KWindowInfo::desktopFileName() const
It returns the desktop file name of the application if known on the
given platform. So far only provided on X11 through
NETWinInfo::desktopFileName.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindowinfox11test.cpp <span style="color: grey">(5dfbcfa67d74244122c86433a40a7ed6923fb1ab)</span></li>
<li>src/kwindowinfo.h <span style="color: grey">(5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3)</span></li>
<li>src/kwindowinfo.cpp <span style="color: grey">(658a0b645797676d4e48585ede3d832333688081)</span></li>
<li>src/kwindowinfo_p.h <span style="color: grey">(45390c06e7b5ad064ea9368ca102b2462a029c06)</span></li>
<li>src/platforms/xcb/kwindowinfo.cpp <span style="color: grey">(eca607e18a979439593e05e1da232548d0e7d139)</span></li>
<li>src/platforms/xcb/kwindowinfo_p_x11.h <span style="color: grey">(68805765fd630c2bc7cf0d77be688333b4a363f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129327/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>