<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129170/">https://git.reviewboard.kde.org/r/129170/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2016, 9:49 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 should now be @since 5.29 (which is good because the translators have one month to translate all these new strings).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Neither ATime nor CTime is actually used in this code, feel free to remove it, maybe in a commit that you would rebase this one upon, or I can do it after you push. So at a minimum, replace MTime with "modification time", fix @since, then push.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks!</p></pre>
</blockquote>
<p>On November 8th, 2016, 11:37 a.m. UTC, <b>Romário Rios</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No problem.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By the way, how should I apply these changes to git? Should I make one big commit or merge my local branch into master?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I was able to review it as a single commit, I'd say it should be pushed as a single commit :-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The removal of ATime and CTime should be a separate commit (ideally before the big one).</p></pre>
<br />
<p>- David</p>
<br />
<p>On November 1st, 2016, 8:10 p.m. UTC, Romário Rios wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Romário Rios.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2016, 8:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This method is similar to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QIODevice::errorString()</code>. I added a public <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">errorString()</code> method and a protected <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">setErrorString()</code> method, to allow <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KArchive</code>'s subclasses to implement their own error messages. I also implemented most error messages from most subclasses.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QVERIFY</code> calls after all errors in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">karchivetests.cpp</code>. Perhaps we'll need more tests, but I'm not sure how to make an archive to fail in some specific way aside from the very basics ("file not found", etc.).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/karchivetest.cpp <span style="color: grey">(d0fbf41)</span></li>
<li>src/k7zip.h <span style="color: grey">(5b95f49)</span></li>
<li>src/k7zip.cpp <span style="color: grey">(692b1db)</span></li>
<li>src/kar.h <span style="color: grey">(85bd650)</span></li>
<li>src/kar.cpp <span style="color: grey">(7204fb1)</span></li>
<li>src/karchive.h <span style="color: grey">(b528a4a)</span></li>
<li>src/karchive.cpp <span style="color: grey">(a1a160a)</span></li>
<li>src/karchive_p.h <span style="color: grey">(256620d)</span></li>
<li>src/krcc.h <span style="color: grey">(18c7d00)</span></li>
<li>src/krcc.cpp <span style="color: grey">(1947dd6)</span></li>
<li>src/ktar.h <span style="color: grey">(4bca898)</span></li>
<li>src/ktar.cpp <span style="color: grey">(f70b155)</span></li>
<li>src/kzip.h <span style="color: grey">(84156c7)</span></li>
<li>src/kzip.cpp <span style="color: grey">(94d4276)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129170/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>