<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128902/">https://git.reviewboard.kde.org/r/128902/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks sensible to me, thanks! What are you planning to use it for?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you push the patch?</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 7th, 2016, 3:21 p.m. CET, stephane cachemaille wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By stephane cachemaille.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2016, 3:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=363200">363200</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add timeout property to Kauth::Action class to be able to change the timeout in QDBusConnection::asyncCall</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested with and without using the new proporty in a kcm module where the action takes more than the default 25s</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/HelperProxy.h <span style="color: grey">(96f4cf1)</span></li>
<li>src/backends/dbus/DBusHelperProxy.h <span style="color: grey">(8f4254c)</span></li>
<li>src/backends/dbus/DBusHelperProxy.cpp <span style="color: grey">(d2620ac)</span></li>
<li>src/backends/fakehelper/FakeHelperProxy.h <span style="color: grey">(d0fb3f5)</span></li>
<li>src/backends/fakehelper/FakeHelperProxy.cpp <span style="color: grey">(a044ac6)</span></li>
<li>src/kauthaction.h <span style="color: grey">(4e33366)</span></li>
<li>src/kauthaction.cpp <span style="color: grey">(34f559d)</span></li>
<li>src/kauthexecutejob.cpp <span style="color: grey">(8b6e177)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128902/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>