<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129283/">https://git.reviewboard.kde.org/r/129283/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2016, 2:22 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129283/diff/1/?file=483327#file483327line46" style="color: black; font-weight: bold; text-decoration: underline;">src/kcursor_p.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">bool</span> <span class="nf">eventFilter</span><span class="p">(</span><span class="n">QObject</span> <span class="o">*</span><span class="n">o</span><span class="p">,</span> <span class="n">QEvent</span> <span class="o">*</span><span class="n">e</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">bool</span> <span class="nf">eventFilter</span><span class="p">(</span><span class="n">QObject</span> <span class="o">*</span><span class="n">o</span><span class="p">,</span> <span class="n">QEvent</span> <span class="o">*</span><span class="n">e</span><span class="p">)</span><span class="hl"> </span><span class="n"><span class="hl">Q_DECL_OVERRIDE</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we remove the "virtual" keyword? Or would that mean that subclasses can no longer override?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Personally, I would remove it, since it's redundant, and only adds noise I have to read. And no, once a function is virtual it'll stay virtual.</p></pre>
<br />
<p>- Dominik</p>
<br />
<p>On October 30th, 2016, 1:33 p.m. UTC, Allen Winter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Allen Winter.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2016, 1:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">all warnings for -Wsuggest-override are gone
make test still passes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kacceleratormanager_p.h <span style="color: grey">(55ab1c1)</span></li>
<li>src/kcharselect_p.h <span style="color: grey">(e4efdab)</span></li>
<li>src/kcharselectdata.cpp <span style="color: grey">(92c1c79)</span></li>
<li>src/kcursor_p.h <span style="color: grey">(fcac8d9)</span></li>
<li>src/kfontaction.h <span style="color: grey">(ae84944)</span></li>
<li>src/kmultitabbar.h <span style="color: grey">(79e62ed)</span></li>
<li>src/kmultitabbar_p.h <span style="color: grey">(6311413)</span></li>
<li>src/kurllabel.h <span style="color: grey">(eeba9e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129283/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>