<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129251/">https://git.reviewboard.kde.org/r/129251/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Oktober 24th, 2016, 11 vorm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-1 it's an established shortcut for cut too. even https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut the selection and store it in the clipboard"</p></pre>
</blockquote>
<p>On Oktober 24th, 2016, 11:05 vorm. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, sorry I didn't know that. Still, the conflict is caused by kconfig itself and it's being worked around by applications. What should we do then?</p></pre>
</blockquote>
<p>On Oktober 24th, 2016, 11:24 vorm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This question was asked last year on the mailing list https://mail.kde.org/pipermail/kde-guidelines/2015-June/thread.html#877. Shift+Del dates back to the medieval ages but was never reverted and is still in our HIG. The discussion didn't end with a solution. And I strongly suggest to have a generic solution that works in all programs. Btw, Krusader uses Shift+Del for permanently delete files.</p></pre>
</blockquote>
<p>On Oktober 24th, 2016, 12:10 nachm. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the link. So if I understand the issue correctly, we should first agree upon another primary shortcut for "Force Delete" and replace Shift+Del with that, at least in KConfig. What about Meta+Del like Thomas suggested?</p></pre>
</blockquote>
<p>On Oktober 24th, 2016, 12:22 nachm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Do we want to retain IBM shortcuts used for decades? Yes, keep shift+del as alternative to ctrl+X; No, drop the unknown shortcut.
2a. If 1)=Yes, do we want to have a similar shortcut for permanently delete? Yes, meta+del/alt+del... No, use something completely different and app specific
2b. If 1)=No, do we want to have an easy shortcut for destructive functions? Yes, use ctrl+del for convenience. No, make it hard to unintentionally run destructive functions; rather use shift+alt+del/ctrl+alt+del or the like.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(My take is 2b and No; but it has to work in <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">every</em> KDE app unless the app defines its own behavior)</p></pre>
</blockquote>
<p>On Oktober 24th, 2016, 9:41 nachm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My suggestion is:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Cut is Ctrl+X and Shift+Delete by default</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">DeleteFile is Shift+Delete by default</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">if</strong> both Cut and DeleteFile are used in the same action collection we disable Shift+Delete from Cut (only if it's there by default and it was not the user that set it on purpose)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That should be <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">doable</em> hopefully.</p></pre>
</blockquote>
<p>On Oktober 25th, 2016, 1:43 nachm. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would not do that. It would be unexpected behavior when the user deletes a file (in for instance dolphin) and expects it to end up in the trash. With your suggestion it would be permanantly deleted.
Regardless of the shortcut, every other modern OS (win and mac) uses the delete key to "move to trash" and a <special>+delete key to permanantly remove the file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lets stick to the established commands over time where Shift+del is permanent delete, not cut text. Other apps should <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</em> use that key combination for a task that isn't permanently deleting something.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just my 2ct.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's do a quick poll: https://plus.google.com/107566594492891737454/posts/QJzpApTeSFg</p></pre>
<br />
<p>- Heiko</p>
<br />
<p>On Oktober 24th, 2016, 10:47 vorm. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Matthew Dawson.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Okt. 24, 2016, 10:47 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=357747">357747</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch removes Shift+Del as secondary shortcut for the Cut action. This shortcut was set back in 2001.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reasons for removing it:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The expected standard behavior for this shortcut is "Permanently delete"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For the reason above, it is also set as primary shortcut for the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">DeleteFile</code> action. This causes conflicts in applications.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For the reason above, many applications (e.g. Dolphin or Digikam) already resolve this conflict on their own.</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Credits to Jan for the investigation: https://bugs.kde.org/show_bug.cgi?id=347373#c2</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Using Shift+Del in Gwenview now works as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/kstandardshortcut.cpp <span style="color: grey">(92eb091382c7ab2110240cef21f29268be787250)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129251/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>