<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3091" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Can't really comment on this, though.<br />
While I'm a huge fan of RAII you don't seem to be returning early from that function, can't you just set the value and set it back at the end without this new class?</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3091" rel="noreferrer">https://phabricator.kde.org/D3091</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, Frameworks, brauch<br /><strong>Cc: </strong>broulik<br /></div>